Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onAppear and onDisappear support #92

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Add onAppear and onDisappear support #92

merged 4 commits into from
Jun 2, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented May 7, 2024

Close #89

@Kyle-Ye Kyle-Ye marked this pull request as draft May 7, 2024 17:22
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 13.92%. Comparing base (ff8fa94) to head (d906b6b).
Report is 1 commits behind head on main.

Files Patch % Lines
...iftUI/View/Modifier/AppearanceActionModifier.swift 0.00% 57 Missing ⚠️
Sources/OpenSwiftUI/Core/Update/Update.swift 0.00% 15 Missing ⚠️
...ources/OpenSwiftUI/Core/View/View/ViewInputs.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   14.12%   13.92%   -0.21%     
==========================================
  Files         199      200       +1     
  Lines        4884     4955      +71     
==========================================
  Hits          690      690              
- Misses       4194     4265      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 2, 2024 09:50
@Kyle-Ye Kyle-Ye merged commit c128f45 into main Jun 2, 2024
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/appear branch June 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] onAppear and onDisappear implementation
1 participant